Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feature) Adds button matchers for default and cancel buttons. #368

Merged
merged 1 commit into from Mar 11, 2017

Conversation

cguckes
Copy link
Contributor

@cguckes cguckes commented Mar 7, 2017

I coded this matcher for myself but began using it in multiple projects, so I figured I could contribute. Let me know if you want anything changed.

I got a few more matchers, but they're not really done yet, I might add them later, if you're interested.

@brcolow
Copy link
Collaborator

brcolow commented Mar 10, 2017

Hey sorry I missed this until now. Thanks for adding tests - that makes it very easy to review.

I restarted Travis as I believe the failures were unrelated flakiness. Looks good at a first glance though. Feel free to open more PRs with your other matchers, I would be happy to review them.

@cguckes
Copy link
Contributor Author

cguckes commented Mar 11, 2017

No worries, I figured the built failed before, with the same error so just go for it :-) I will add the rest once I sanitized them and fixed the code style.

@brcolow brcolow merged commit 3635bab into TestFX:master Mar 11, 2017
@brcolow
Copy link
Collaborator

brcolow commented Mar 11, 2017

Merged. Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants