(fix) Pass along application parameters. #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
However do it in a way that avoids compile-time dependencies on the JavaFX private API for Java 9 compatibility. This is accomplished via the Reflection API. Support for registering parameters was removed in e910aee - this brings it back. Fixes TestFX#380
brcolow
force-pushed
the
issue-380
branch
2 times, most recently
from
61c8af5
to
45e6645
Compare
Still not actually working, but at least it is working a bit more than it was :).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
However do it in a way that avoids compile-time dependencies on the
JavaFX private API for Java 9 compatibility. This is accomplished
via the Reflection API.
Support for registering parameters was removed in e910aee - this
brings it back.
Fixes #380