Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] (refactor) Fix many IntelliJ inspection issues. #382

Merged
merged 1 commit into from Mar 28, 2017

Conversation

brcolow
Copy link
Collaborator

@brcolow brcolow commented Mar 27, 2017

No description provided.

@brcolow brcolow force-pushed the intellij-inspections branch 3 times, most recently from 71a220c to 2e2965e Compare March 27, 2017 22:55
@brcolow brcolow merged commit 9d184f0 into TestFX:master Mar 28, 2017
@brcolow brcolow deleted the intellij-inspections branch March 28, 2017 00:30
@hastebrot
Copy link
Member

hastebrot commented Mar 28, 2017

This removes unnecessary public keywords in interfaces, and generic type declarations. 👍

It also replaces some of the lambda functions blocks with single lambda functions, or uses method references. Hmm, I'm not a big fan of Java 8 method references. 😐

@brcolow
Copy link
Collaborator Author

brcolow commented Mar 28, 2017

Okay, if you would like me to revert the method reference changes I can. I think they are more succinct, but that's just my opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants