Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for updating build custom fields in XML-RPC API #47

Conversation

ConorPKeegan
Copy link
Contributor

Changes

  • Added a function updateBuildCustomFieldsValues to xmlrpc.class.php to update build custom fields using XML-RPC. It is based on the function updateTestSuiteCustomFieldDesignValue
  • Added new error code to identify when no custom fields are linked to the specified build
  • Added a new error message in en_GB, which relates to the new error code for the build not being linked to any custom fields

Description

  • The UI supports the use of custom fields for builds, but there was no support for this in the API for XML-RPC. This functionality will make test automation easier to use

Added a function which is similar to updating testcase custom fields
@ConorPKeegan
Copy link
Contributor Author

@mazimkhan @PrzemekWirkus

@mazimkhan
Copy link

@fmancardi can you please review this change?

@fmancardi
Copy link
Contributor

Hi
hope you can understand that I've my own planning and this issue is not
priority for me now.
Then I do not have any ETA for this taks.
And to be honest, I do not like to be 'pinged' for this kind of things and
just after a couple of days.
Code is available => you can apply to your installation and test and use it
if is urgent for you

On Mon, Aug 1, 2016 at 10:40 AM, Mohammad Azim Khan <
notifications@github.com> wrote:

@fmancardi https://github.com/fmancardi can you please review this
change?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#47 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAOYsZpJU2OjFabfNEilf5da2cHHk991ks5qbbD9gaJpZM4JUEGM
.

Francisco Mancardi

@mazimkhan
Copy link

Thanks for your reply. Didn't intend to bother you. Only reason was that this change is dependency to testlink-java-api -> testlink-plugin that is also modified. But anyways we have applied the changes locally.

Hope you pick it up soon.

Cheers

'msg' => 'Custom Field:' . $cfName . ' skipped ');
}

return $ret;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ConorPKeegan Returning from within the loop will not process all the custom fields received.

All fields are processed before the result is returned
@mazimkhan
Copy link

mazimkhan commented Oct 7, 2016

It is over a month now and related changes in jenkinsci/testlink-plugin#23 can not be accepted until this PR is merged. Really appreciate if this contribution is honoured in time. We have more changes lined up in testlink-plugin that we want to do on top of this.

@fmancardi
Copy link
Contributor

Again:
Code is available => you can apply to your installation and test and use it if is urgent for you.

@mazimkhan
Copy link

I hope you understand there is maintenance effort in having our own fork and still wanting to get new releases. Secondly it is made worse by this PRs dependency in another useful plugin.
We have just been started to look into TL. A healthy support will give us confidence in using it :)

@fmancardi
Copy link
Contributor

IMHO this discussion here about how healthy is the support, is OFF TOPIC. In any case Testlink offers free best effort support, if you need a different kind of support you can ask for buying support

@fmancardi fmancardi merged commit 6f5f6fb into TestLinkOpenSourceTRMS:testlink_1_9 Oct 7, 2016
@mazimkhan
Copy link

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants