Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add/remove testcases navigation requirements #81

Merged
merged 56 commits into from Dec 17, 2017
Merged

Add/remove testcases navigation requirements #81

merged 56 commits into from Dec 17, 2017

Conversation

Tigeek
Copy link
Contributor

@Tigeek Tigeek commented Feb 27, 2017

Add functionnality in the "Add / Remove Test Cases" screen of the "Test Plan" the groupings are made by "test case", we had the need to sort them by "cover of requirement" and then add all Tests covering a requirement in the test plan.

@Tigeek
Update strings.txt
6aae2e3 
add covverage select language
@Tigeek
Update strings.txt
3bb4226 
requirement select language
@Tigeek
Update inc_filter_panel.tpl
e226a7f 
add test group by in filter
@Tigeek
Update testlink_library.js
885d01a 
add click action in tree requirements
@Tigeek
Create getreqcoveragenodes.php
1a0e921 
action called when select "ReqCoverage"
@Tigeek
Update tlTestCaseFilterControl.class.php
8c30e91 
filter controller
@Tigeek
Update requirement_spec_mgr.class.php
4490767
@Tigeek
Update specview.php
8a2c52d 
get testcase by coverage
@Tigeek
Update tree.class.php
87aee20 
get requirements for create tree node
@Tigeek
Update treeMenu.inc.php
62130f3 
create tree requirement for get test case by requirements.
@ChuckNorrison
Copy link
Contributor

  • A Tests Grouped by Option was added in Settings
  • After selecting Req.Coverage, the tree structure changed to Requirements view
  • After selecting a Requirement, nothing happens. The view on the right is still unchanged

Some Ideas? Anyway i think that could be useful if it works as expected, thanks.

@Tigeek
Copy link
Contributor Author

Tigeek commented Feb 28, 2017

I check and keep you informed.

@Tigeek
Copy link
Contributor Author

Tigeek commented Feb 28, 2017

Sorry, I have forget push 2 files.
I check by taking over the branch it works now.
Thanks.

@ChuckNorrison
Copy link
Contributor

Great, now it works :)

@Tigeek
Update planAddTC.php
579cd96 
Recover the test cases covered by the child requirements, when you select a requirement.
@Tigeek
Update requirement_spec_mgr.class.php
672999e 
Recover the test cases covered by the child requirements, when you select a requirement.
@Tigeek
Update tlTestCaseFilterControl.class.php
96218a3 
Correction, display of the tree when clicking on the button "advanced filter"
@Tigeek
Update treeMenu.inc.php
76d317d 
Correction, display of the tree when clicking on the button "advanced filter"
@Tigeek
Copy link
Contributor Author

Tigeek commented Mar 2, 2017

Correction, display of the tree when clicking on the button "advanced filter"
and add litle functionnality, get the test cases covered by the child requirements, when you select a requirement.

@Tigeek
Update texts.php
6d50bba 
Add translation for add/remove tasecase into testplan documentation.
@Tigeek
Update texts.php
ea43902 
Add translation for add/remove tasecase into testplan documentation.
@Tigeek
Update texts.php
39f30e8 
Add translation for add/remove tasecase into testplan documentation.
@Tigeek
Update texts.php
d1eb8be 
Add translation for add/remove tasecase into testplan documentation.
@Tigeek
Update texts.php
d453c23 
Add translation for add/remove tasecase into testplan documentation.
@Tigeek
Update texts.php
5573341 
Add translation for add/remove tasecase into testplan documentation.
@Tigeek
Update texts.php
d723812 
Add translation for add/remove tasecase into testplan documentation.
@Tigeek
Update texts.php
09937c0 
Add translation for add/remove tasecase into testplan documentation.
@Tigeek
Update texts.php
9847f04 
Add translation for add/remove tasecase into testplan documentation.
@fmancardi
Copy link
Contributor

Hi
thanks for your work
I can not accept your pull requests this way with marks of where your code start and end.
I'm going to understand how to add your code to stable dev line

@Tigeek
Copy link
Contributor Author

Tigeek commented Mar 4, 2017

Hello,

I understand you. I will clean the code and republish it in about ten days.

Have a good day.

@fmancardi
Copy link
Contributor

Please do not touch anything, I'm going to refactor the code, then I will contact you
have a nice week end

@Tigeek
Copy link
Contributor Author

Tigeek commented Mar 4, 2017

Ok. Thanks.

@fmancardi
Copy link
Contributor

changes on frmWorkArea.php => rejected

@fmancardi
Copy link
Contributor

Please do not leave comments on code that are wrong, like author of method or function description. It's lot better to have no info that wrong info, because effort for maintenance increase to an unacceptable level

@Tigeek
Copy link
Contributor Author

Tigeek commented Mar 4, 2017

Sorry, i will be vigilant at this the next time.

Fazril and others added 6 commits March 14, 2017 14:19
@Fazril
Respect for remark and beginning clen code
ee27ebb 
1- delete start/end coments.
2- delete modification in frmWorkArea.
3- beginning clean code and coments.
@Tigeek
Revert "Respect for remark and beginning clen code"
2cb5fdc 
This reverts commit ee27ebb.
@Tigeek
Respect for remark and beginning clean code
9ac1d1f 
1- delete start/end coments.
2- delete modification in frmWorkArea.
3- beginning clean code and coments.
@Tigeek
Merge branch 'testlink_1_9' into Add/Remove-Testcases-Navigation-REQU…
7a11781 
…IREMENTS
@Tigeek
resolve conflict
dcdb662
@Tigeek
Add btn for get child parent relation in requirements.
deeb96d 
Add btn for get child parent relation in requirements
@Tigeek
Copy link
Contributor Author

Tigeek commented Mar 16, 2017

The translation of the different label and the cleaning of the code has been done.

@Tigeek
Merge branch 'testlink_1_9' into Add/Remove-Testcases-Navigation-REQU…
abf1b10 
…IREMENTS
@Tigeek
get requirement in recursive folders.
e44996d
@Tigeek
Merge remote-tracking branch 'refs/remotes/TestLinkOpenSourceTRMS/tes…
6f471e1 
…tlink_1_9' into Add/Remove-Testcases-Navigation-REQUIREMENTS

# Conflicts:
#	locale/en_GB/strings.txt
#	locale/pt_BR/strings.txt
@Tigeek
Merge branch 'testlink_1_9' of https://github.com/TestLinkOpenSourceT…
25cb13c 
…RMS/testlink-code into testlink_1_9
@Tigeek
Merge branch 'testlink_1_9' of https://github.com/TestLinkOpenSourceT…
c2797e3 
…RMS/testlink-code into testlink_1_9
@Tigeek
Merge branch 'testlink_1_9' of https://github.com/TestLinkOpenSourceT…
1eb424f 
…RMS/testlink-code into testlink_1_9
@Tigeek
Merge
daffe4e 
merge
@Tigeek
Show requirement name in testplan when user click on folder
8841751 
Show requirement name in testplan when user click on folder
And correction in folder recusive
@Tigeek
Copy link
Contributor Author

Tigeek commented Mar 29, 2017

For information,
The link between the "parent / child" requirement is only made when clicking on a requirement, and not when clicking on a folder in order to avoid excessive loading times.

@fmancardi
Copy link
Contributor

Unfortunately IMHO all this development has become a great mess, then I will not be able to accept it as is. I will need to get code and do a deep code review.

@MrBricodage
Copy link
Contributor

Please explain which part is "a great mess". Code or commits?

I plan to provide a user manual with screenshots to explain what have been done in this branch from a user point of view (menus, options).

@fmancardi
Copy link
Contributor

I prefer to explain in a private discussion via mail (thing that i've tried to do to coordinate development since the beggining of this development)

@fmancardi fmancardi closed this Apr 2, 2017
@fmancardi fmancardi reopened this Dec 17, 2017
@fmancardi fmancardi merged commit 0853b06 into TestLinkOpenSourceTRMS:testlink_1_9 Dec 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@Tigeek @ChuckNorrison @fmancardi @MrBricodage @Fazril