-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MockFileSystem extensions #32
MockFileSystem extensions #32
Comments
hi @rcdailey , If not the only alternative is to create a second library in this repo, something like TestableIO.System.IO.Abstractions.TestingHelpers.Extensions, otherwise the normal extensions would depend on the testing library which doesn't make any sense. |
I'm also fine adding them to |
- `AddEmptyFile()` added which is a convenience wrapper for `AddFile()` with an empty `MockFileData`. - `AddFile()` overload added which consumes an `IFileInfo`. - `AddDirectory()` overload added which consumes an `IDirectoryInfo`. - `GetFile()` overload added which consumes an `IFileInfo`. Unit test added for `AddEmptyFile()` but not the others, as the test code for them would have very little value. Fixes TestableIO/System.IO.Abstractions.Extensions#32
- `AddEmptyFile()` added which is a convenience wrapper for `AddFile()` with an empty `MockFileData`. - `AddFile()` overload added which consumes an `IFileInfo`. - `AddDirectory()` overload added which consumes an `IDirectoryInfo`. - `GetFile()` overload added which consumes an `IFileInfo`. Unit test added for `AddEmptyFile()` but not the others, as the test code for them would have very little value. Fixes TestableIO/System.IO.Abstractions.Extensions#32
- `AddEmptyFile()` added which is a convenience wrapper for `AddFile()` with an empty `MockFileData`. - `AddFile()` overload added which consumes an `IFileInfo`. - `AddDirectory()` overload added which consumes an `IDirectoryInfo`. - `GetFile()` overload added which consumes an `IFileInfo`. Unit test added for `AddEmptyFile()` but not the others, as the test code for them would have very little value. Fixes TestableIO/System.IO.Abstractions.Extensions#32
- `AddEmptyFile()` added which is a convenience wrapper for `AddFile()` with an empty `MockFileData`. - `AddFile()` overload added which consumes an `IFileInfo`. - `AddDirectory()` overload added which consumes an `IDirectoryInfo`. - `GetFile()` overload added which consumes an `IFileInfo`. Unit test added for `AddEmptyFile()` but not the others, as the test code for them would have very little value. Fixes TestableIO/System.IO.Abstractions.Extensions#32 Co-authored-by: Florian Greinacher <florian@greinacher.de>
Would you find the below extension methods useful? If so, I am happy to open a pull request. I'm hesitant to do so right away because I'm not sure if these should be extension methods in this library or if I should contribute them as actual class members upstream (upstream being the actual
IO.Abstractions
package).I found these extension methods to be absolutely invaluable in my own code base in conjunction with the Extensions package. It eliminates a lot of boilerplate in my unit tests, namely these:
If you could provide some guidance and feedback, I'm happy to move this to a PR. Thanks for your time!
The text was updated successfully, but these errors were encountered: