Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass IFileSystem into FileWrapper instead of FileSystem #432

Merged
merged 1 commit into from Dec 23, 2018

Conversation

kirbatious
Copy link
Contributor

This will allow replacement file systems to be used and is the same pattern used in all the other classes.

@fgreinacher
Copy link
Contributor

Good catch, thanks!

@fgreinacher fgreinacher merged commit bf6d21c into TestableIO:master Dec 23, 2018
@fgreinacher fgreinacher mentioned this pull request Jan 5, 2019
fgreinacher added a commit that referenced this pull request Jan 5, 2019
- Do not throw exception when calling DirectoryInfoWrapper.Parent for the root directory (#430) by @wexman
- Fix MockDirectoryInfo GetFiles for UNC paths caused by bug in StringExtensions.NormalizeSlashes (#422) by @DeveloperGuo
- Pass IFileSystem into FileWrapper instead of FileSystem to allow replacement file systems to be used (#432) by @kirbatious
- Make sure FileNotFound exceptions contain path and proper message (#427) by @fgreinacher
- Do not delete directories that start with the same path (#433) by @updateaman
@fgreinacher
Copy link
Contributor

Fixed in https://www.nuget.org/packages/System.IO.Abstractions/3.0.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants