Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: MockFile - clone the bytes in read/write allbytes methods #856

Merged
merged 4 commits into from
Jun 9, 2022
Merged

fix: MockFile - clone the bytes in read/write allbytes methods #856

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
914fef8
clone the bytes in read/write allbytes methods
May 28, 2022
461b6cc
Merge branch 'main' into fix/mockfile-reading-writing-all-bytes
jamesmoore May 30, 2022
537ce70
unix/macos path fix
May 30, 2022
4dfb0ab
Merge branch 'fix/mockfile-reading-writing-all-bytes' of https://gith…
May 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/System.IO.Abstractions.TestingHelpers/MockFile.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -538,7 +538,7 @@ public override byte[] ReadAllBytes(string path)
throw CommonExceptions.FileNotFound(path);
}
mockFileDataAccessor.GetFile(path).CheckFileAccess(path, FileAccess.Read);
return mockFileDataAccessor.GetFile(path).Contents;
return mockFileDataAccessor.GetFile(path).Contents.ToArray();
}

/// <inheritdoc />
Expand Down Expand Up @@ -784,7 +784,7 @@ public override void WriteAllBytes(string path, byte[] bytes)
mockFileDataAccessor.PathVerifier.IsLegalAbsoluteOrRelative(path, "path");
VerifyDirectoryExists(path);

mockFileDataAccessor.AddFile(path, new MockFileData(bytes));
mockFileDataAccessor.AddFile(path, new MockFileData(bytes.ToArray()));
}

/// <summary>
Expand Down
22 changes: 22 additions & 0 deletions tests/System.IO.Abstractions.TestingHelpers.Tests/MockFileReadAllBytesTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,28 @@ public void MockFile_ReadAllBytes_ShouldTolerateAltDirectorySeparatorInPath()

Assert.AreEqual(data, fileSystem.File.ReadAllBytes(altPath));
}

[Test]
public void MockFile_ReadAllBytes_ShouldReturnANewCopyOfTheFileContents()
{
var path = XFS.Path(@"c:\something\demo.bin");
var fileSystem = new MockFileSystem(new Dictionary<string, MockFileData>
{
{ path, new MockFileData(new byte[] { 1, 2, 3, 4 }) }
});

var firstRead = fileSystem.File.ReadAllBytes(path);

var secondRead = fileSystem.File.ReadAllBytes(path);

for (int i = 0; i < firstRead.Length; i++)
{
firstRead[i] += 1;
}

Assert.AreNotEqual(firstRead, secondRead);
}

#if FEATURE_ASYNC_FILE
[Test]
public async Task MockFile_ReadAllBytesAsync_ShouldReturnOriginalByteData()
Expand Down
21 changes: 21 additions & 0 deletions tests/System.IO.Abstractions.TestingHelpers.Tests/MockFileWriteAllBytesTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,27 @@ public void MockFile_WriteAllBytes_ShouldThrowAnArgumentNullExceptionIfBytesAreN
Assert.That(exception.ParamName, Is.EqualTo("bytes"));
}

[Test]
public void MockFile_WriteAllBytes_ShouldWriteASeparateCopyToTheFileSystem()
{
var fileSystem = new MockFileSystem();
string path = XFS.Path(@"c:\something\file.bin");
fileSystem.AddDirectory(XFS.Path(@"c:\something"));
var fileContent = new byte[] { 1, 2, 3, 4 };

fileSystem.File.WriteAllBytes(path, fileContent);

for(int i = 0; i < fileContent.Length; i++)
{
fileContent[i] += 1;
}

var readAgain = fileSystem.File.ReadAllBytes(path);

Assert.AreNotEqual(fileContent, readAgain);
}


#if FEATURE_ASYNC_FILE
[Test]
public void MockFile_WriteAllBytesAsync_ShouldThrowDirectoryNotFoundExceptionIfPathDoesNotExists()
Expand Down