Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add GetFileSystemEntries with SearchOption #878

Merged

Conversation

rkm
Copy link
Collaborator

@rkm rkm commented Aug 22, 2022

Fixes #775.

@rkm rkm changed the title Add GetFileSystemEntries with SearchOption feat: Add GetFileSystemEntries with SearchOption Aug 22, 2022
@rkm rkm force-pushed the fix/775-GetFileSystemEntries-SearchOption branch from 66e36f7 to 9c17a48 Compare August 22, 2022 17:50
@rkm rkm requested a review from fgreinacher August 25, 2022 22:34
Copy link
Contributor

@fgreinacher fgreinacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this @rkm!

I left one suggestion, otherwise this looks great!

Copy link
Contributor

@fgreinacher fgreinacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks again!

@mergify mergify bot merged commit de4facf into TestableIO:main Sep 10, 2022
@github-actions
Copy link

This is addressed in release v17.2.1.

@github-actions
Copy link

This is addressed in release v17.2.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state: released Issues that are released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Directory.GetFileSystemEntries is missing the SearchOption parameter
2 participants