Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admins can leave a leaderboard and there won't be more admins #24

Closed
Eldemarkki opened this issue May 12, 2022 · 0 comments · Fixed by #28
Closed

Admins can leave a leaderboard and there won't be more admins #24

Eldemarkki opened this issue May 12, 2022 · 0 comments · Fixed by #28
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Eldemarkki
Copy link
Member

Currently if a leaderboard only has user X in it, and X is an admin, they can leave the leaderboard. Then the leaderboard won't have any admins, and so no one can delete it and it will stay in the database forever.

I propose that an admin should only be allowed to leave a leaderboard if there are other admins left. If there aren't any, the last admin should only be able to delete the leaderboard.
@lajp lajp added enhancement New feature or request good first issue Good for newcomers labels May 12, 2022
lajp added a commit to lajp/testaustime-backend that referenced this issue May 17, 2022
@lajp
leaderboards: Prevent last admin from leaving. Fix Testaustime#24
c99fbc7
@lajp lajp linked a pull request May 17, 2022 that will close this issue
leaderboards: Prevent last admin from leaving. Fix #24 #28
Merged
@lajp lajp closed this as completed in #28 May 19, 2022
lajp added a commit that referenced this issue May 19, 2022
@lajp
leaderboards: Prevent last admin from leaving. Fix #24 (#28)
dfadd84
@Eldemarkki Eldemarkki mentioned this issue Jul 28, 2022
Open
@DrVilepis DrVilepis mentioned this issue Apr 17, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

leaderboards: Prevent last admin from leaving. Fix #24 lajp/testaustime-backend
2 participants
@lajp @Eldemarkki