Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

viewClass doesn't check for non-exist class #5

Open
Tex-Tang opened this issue Nov 11, 2022 · 1 comment
Open

viewClass doesn't check for non-exist class #5

Tex-Tang opened this issue Nov 11, 2022 · 1 comment

Comments

@Tex-Tang
Copy link
Owner

Tex-Tang commented Nov 11, 2022

Issue Description

viewClass command doesn't check for invalid class

Expected Result

Show error message to prompt user that class doesn't exist

Actual Result

list 0 students

Additional Details / Screenshot

image.png

@nus-se-bot
Copy link

nus-se-bot commented Nov 14, 2022

Team's Response

This was an intended feature by the team to indicate to users that there are no students in the class:
This works this way as currently there is no 'Class creation' mechanism in this application. Hence it is more apt to describe it as there are no students who have been given that particular class.
Overall, our team did recognise both methods and we concluded that since both throwing an error and telling the user that there are 0 students in the class have the exact same meaning to the user and will not cause confusion, we have decided to go with the latter.

Nonetheless, we recognise why it may seem more apt to indicate an error and that is something that we would want to pursue beyond v1.4 after we are able to implement a 'Class creation' mechanism.

Items for the Tester to Verify

❓ Issue response

Team chose [response.Rejected]

  • I disagree

Reason for disagreement: "No student" and "No class" are two different things. For example, when a teacher has a typo in viewClass, she might think that there is no student in class instead of "Oh I made a typo" if the app gives better error message.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants