Add hotkeys for undo and redo #1576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xiao-zhen-Liu
requested changes
Jul 7, 2022
core/new-gui/src/app/workspace/component/navigation/navigation.component.ts
Outdated
Show resolved
Hide resolved
core/new-gui/src/app/workspace/component/navigation/navigation.component.ts
Outdated
Show resolved
Hide resolved
core/new-gui/src/app/workspace/component/navigation/navigation.component.ts
Outdated
Show resolved
Hide resolved
Xiao-zhen-Liu
requested changes
Jul 12, 2022
core/new-gui/src/app/workspace/component/workflow-editor/workflow-editor.component.ts
Outdated
Show resolved
Hide resolved
core/new-gui/src/app/workspace/component/workflow-editor/workflow-editor.component.ts
Outdated
Show resolved
Hide resolved
core/new-gui/src/app/workspace/component/workflow-editor/workflow-editor.component.ts
Outdated
Show resolved
Hide resolved
core/new-gui/src/app/workspace/component/workflow-editor/workflow-editor.component.ts
Outdated
Show resolved
Hide resolved
Xiao-zhen-Liu
approved these changes
Jul 13, 2022
core/new-gui/src/app/workspace/component/workflow-editor/workflow-editor.component.ts
Outdated
Show resolved
Hide resolved
sadeemsaleh
reviewed
Jul 14, 2022
| private _handleKeyboardAction(event: any) { | ||
| this._onProcessKeyboardActionObservable = new Subject(); | ||
| event.preventDefault(); | ||
| this.workflowVersionService |
There was a problem hiding this comment.
Why is this workflowversion preview in this logic?
There was a problem hiding this comment.
This is listening for when workflow version preview is opened, do not enable undo/redo hotkey.
Xiao-zhen-Liu
added a commit
that referenced
this pull request
Jul 14, 2022
This reverts commit 70278c5.
Xiao-zhen-Liu
pushed a commit
that referenced
this pull request
Jul 14, 2022
The PR fixes a bug introduced by #1576, which blocks all other keyboard events other than undo/redo hotkeys.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds hotkeys for undo and redo button, and addresses issue #1553.
Before:
After: