Move the input dialogs over to the newer Screen result approach
#23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that I'm moved over to the dismiss/result approach for modal screens, I don't really need to track an ID any more; the code that sets up the callback should be pointing to the correct callback. This means that InputDialog can be simply typed as str.
Not needed now that I've simplified the return value of InputDialog.
This removes the need for a "requester" to be passed, and also removes anything to do with ID and cargo that was still left over.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As outlined in #9, since starting this, and indeed somewhat motivated by the work in here, Textual now has a method of returning results from a screen (best used with
ModalScreen, although not exclusive to it). Now that this approach is stable in Textual this is a set of changes to move Frogmouth's dialogs over to result-returning rather than message-sending.