Add support for short URLs #77
Conversation
|
Could you please modify not to change the version number, and provide details of the problem being solved and how it's solving it. |
The current version of 'frogmouth' v0.9.0 if you pass a short URL like those generated on Twitter, 'frogmouth' opens the default browser with the final URL
This PR adds the behavior that if a short URL is passed follows the redirect and continues with the validation that the "path" is a file with extension Markdown, resulting the Markdown content being rendered in the Viewer widget |
| @@ -34,8 +37,20 @@ def _(resource: str) -> bool: | |||
|
|
|||
|
|
|||
| @maybe_markdown.register | |||
| def _(resource: URL) -> bool: | |||
| return maybe_markdown(resource.path) | |||
| async def _(resource: URL) -> bool: | |||
There was a problem hiding this comment.
While I can see why this would be desirable (even if it's somewhat niche), I'm not sure this is the way go to about it. This suddenly makes maybe_markdown into a single dispatch method that is non-async in some cases but async in another (pyright, for example, quite right complains about this). Also, this suddenly turns the check for a possible Markdown file on the end of a URL into a much more expensive test.
I think there's some merit in handling this case, but I don't think this is the way to go about this.
Ex: Twitter short URL
py -m frogmouth https://t.co/5AU9qe7pQ1