Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] python3.10 test failures #1216

Closed
jsmolic opened this issue May 6, 2021 · 7 comments
Closed

[BUG] python3.10 test failures #1216

jsmolic opened this issue May 6, 2021 · 7 comments
Labels
accepted Task was accepted blocked

Comments

@jsmolic
Copy link

jsmolic commented May 6, 2021

When running tests with Python 3.10.0b1 (Gentoo Linux), the following tests fail:

FAILED tests/test_inspect.py::test_inspect_integer_with_methods - assert ("╭──────────────── <class 'int'> ─────────────────╮...
FAILED tests/test_log.py::test_log - AssertionError: assert ('\x1b[2;36m[TIME]\x1b[0m\x1b[2;36m '\n '\x1b[0m                 ...
FAILED tests/test_pretty.py::test_pretty_dataclass - assert "ExampleDataclass(foo=1000, bar='Hello, World', baz=['foo', 'bar'...
FAILED tests/test_segment.py::test_repr - assert "Segment('foo', None, [(ControlType.HOME, 0)])" == "Segment('foo', None, [

I'm attaching the full build log

build.log

@willmcgugan
Copy link
Collaborator

Those error seem to be due to a change in the repr format of various objects in Python3.10. Not a bug per-se but I'll update the tests in the next release.

@willmcgugan willmcgugan added accepted Task was accepted and removed Needs triage labels May 9, 2021
@willmcgugan
Copy link
Collaborator

Tried to add the beta to GH Actions, but running in to this error. Will come back to it when that's resolved.

@sondrelg

This comment has been minimized.

@willmcgugan
Copy link
Collaborator

Thanks @sondrelg It's not terribly urgent, but I'll give that a try!

@mgorny
Copy link
Contributor

mgorny commented Jul 13, 2021

Ping.

@willmcgugan
Copy link
Collaborator

Fixed!

@github-actions
Copy link

github-actions bot commented Nov 7, 2021

Did I solve your problem?

Consider sponsoring the ongoing work on Rich and Textual.

Or buy me a coffee to say thanks.

Will McGugan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Task was accepted blocked
Projects
None yet
Development

No branches or pull requests

4 participants