Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exploratory Contribution: MUD Support (MXP/Pueblo) #1288

Closed
wants to merge 3 commits into from

Conversation

volundmush
Copy link

@volundmush volundmush commented Jun 11, 2021

I don't expect this Pull Request to pass as-is. It would definitely need a bit more polish for that. But see the description!

Basically, I'm looking for input on whether this SORT of contribution would be desired, before I commit to going further.

Please let me know if it's not; then I might have to fork. I tried to integrate these features via monkey-patching, but it caused a lot of problems.

Type of changes

  • Bug fix
  • [X ] New feature
  • Documentation / docstrings
  • Tests
  • Other

Checklist

  • [X ] I've run the latest black with default args on new code.
  • I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
  • I've added tests for new code.
  • I accept that @willmcgugan may be pedantic in the code review.

Description

This patch would add support for MXP (Mud eXtension Protocol) and Pueblo. This required some minor edits to Text, Style, and Console. Because I'm working on a project that relies heavily on Text objects and treating them largely like normal strings, the Text object API was also expanded to handle much more of the Python String API.

Also added the ability to specify BOX type for Traceback printing, because the default one looks terrible in monospace MUD setups.

@willmcgugan
Copy link
Collaborator

You've done some very interesting work there, but MUD support is probably too niche to add to the core library. You are probably better off with a fork of the lib. You could even publish it on Pypy as rich-mud or something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants