json: add support for default encoder #1547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1547 +/- ##
==========================================
- Coverage 99.73% 99.69% -0.04%
==========================================
Files 71 71
Lines 6788 6947 +159
==========================================
+ Hits 6770 6926 +156
- Misses 18 21 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Thanks |
skshetry
added a commit
to skshetry/dvc
that referenced
this pull request
Nov 7, 2021
It comes with the support for no. of parameters that matches with json.dumps. See: Textualize/rich#1547 and Textualize/rich#1644. Also added support for printing json to stderr. Before we used to use json.dumps and rich.json.JSON based on isatty. Now we use rich.print_json on both tty and non-tty conditions, which may avoid different behaviours in the future.
2 tasks
efiop
pushed a commit
to iterative/dvc
that referenced
this pull request
Nov 7, 2021
It comes with the support for no. of parameters that matches with json.dumps. See: Textualize/rich#1547 and Textualize/rich#1644. Also added support for printing json to stderr. Before we used to use json.dumps and rich.json.JSON based on isatty. Now we use rich.print_json on both tty and non-tty conditions, which may avoid different behaviours in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of changes
Checklist
Description
Please describe your changes here. If this fixes a bug, please link to the issue, if possible.
This adds a
defaultencoder support forJSON.from_datawhich will be called for objects whichjson.dumpscannot serialize by default.