Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend tabs with styles #3061

Merged
merged 9 commits into from
Jul 29, 2023
Merged

Extend tabs with styles #3061

merged 9 commits into from
Jul 29, 2023

Conversation

willmcgugan
Copy link
Collaborator

The Text.extend_tabs method was previously not taking in to account the spans. Basically it would replace tabs with unstyled spaces. This resolves that issue by extending the style(s) on the tab to cover the new space characters

Screenshot 2023-07-28 at 22 00 06

@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2023

Codecov Report

Patch coverage: 94.73% and project coverage change: -0.03% ⚠️

Comparison is base (31c1fb6) 98.31% compared to head (d5b3282) 98.29%.
Report is 1 commits behind head on master.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3061      +/-   ##
==========================================
- Coverage   98.31%   98.29%   -0.03%     
==========================================
  Files          74       74              
  Lines        8016     8036      +20     
==========================================
+ Hits         7881     7899      +18     
- Misses        135      137       +2     
Flag Coverage Δ
unittests 98.29% <94.73%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
rich/text.py 99.17% <94.73%> (-0.32%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@willmcgugan willmcgugan merged commit 62c8aba into master Jul 29, 2023
19 checks passed
@willmcgugan willmcgugan deleted the tabs-spaces branch July 29, 2023 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants