Do not join refresh thread for Live under lock #928
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the Live.stop() method, release self._lock before joining the refresh thread. Re-acquire the lock when Thread.join returns or raises an exception. This fixes the following deadlock: 1. (Live.stop): The main thread acquires the lock. 2. (_RefreshThread.run) The refresh thread waits for the lock. 3. (Live.stop) The main thread stops and joins the refresh thread. Deadlock occurs because the main thread waits for the refresh thread to exit, while the refresh thread waits for the main thread to release the lock.
Codecov Report
@@ Coverage Diff @@
## master #928 +/- ##
=======================================
Coverage 99.54% 99.54%
=======================================
Files 58 58
Lines 5065 5068 +3
=======================================
+ Hits 5042 5045 +3
Misses 23 23
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Closing if favor of #930 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
Live.stop()method, releaseself._lockbefore joining the refresh thread. Re-acquire the lock whenThread.joinreturns or raises an exception.This fixes the following deadlock:
Live.stop: The main thread acquires the lock._RefreshThread.run: The refresh thread waits for the lock.Live.stop: The main thread stops and joins the refresh thread.Deadlock occurs because the main thread waits for the refresh thread to exit, while the refresh thread waits for the main thread to release the lock.
Fixes #927