Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example showing that builds on Windows fail #12

Closed
wants to merge 2 commits into from

Conversation

pavelkraleu
Copy link

@pavelkraleu pavelkraleu commented Aug 11, 2023

This is only example showing that command textual or at least its builds fail on Windows.

Here I only added tests for command textual keys which is already implemented but not tested.

This confirms that issues I have encountered in this PR are not caused by my actions 🙂.

Do you have any idea what could be causing this @rodrigogiraoserrao ? For example am I invoking the tests incorrectly? 🙏

@rodrigogiraoserrao
Copy link
Contributor

rodrigogiraoserrao commented Aug 17, 2023

The issue is that textual keys and textual widgets open Textual apps, while the other tests for textual --version and textual diagnose print some output and then exit.

So, in a way, you are “invoking the tests incorrectly”, but you don't need to worry about that for your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants