Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App title and sub_title should be converted to strings #2521

Closed
willmcgugan opened this issue May 9, 2023 · 2 comments · Fixed by #2532
Closed

App title and sub_title should be converted to strings #2521

willmcgugan opened this issue May 9, 2023 · 2 comments · Fixed by #2532
Assignees
Labels
enhancement New feature or request Task

Comments

@willmcgugan
Copy link
Collaborator

I'm thinking that App.title and App.sub_title should be converted to strings.

Balancing convenience with hiding errors, this is probably the right thing to do 90% of the time.

@davep davep added enhancement New feature or request Task labels May 9, 2023
@rodrigogiraoserrao rodrigogiraoserrao self-assigned this May 9, 2023
rodrigogiraoserrao added a commit that referenced this issue May 9, 2023
@davep
Copy link
Contributor

davep commented May 10, 2023

(More a thought for a spin-off issue than something for this issue) With the same motivation: should we do the same for border titles too?

@github-actions
Copy link

Don't forget to star the repository!

Follow @textualizeio for Textual updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants