Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline mode and the command palette don't play well together #4385

Closed
davep opened this issue Apr 4, 2024 · 3 comments · Fixed by #4393 or #4401
Closed

Inline mode and the command palette don't play well together #4385

davep opened this issue Apr 4, 2024 · 3 comments · Fixed by #4393 or #4401
Labels
bug Something isn't working

Comments

@davep
Copy link
Collaborator

davep commented Apr 4, 2024

As of Textual v0.55.1, if you run an application in inline mode, and then call on the command palette, the result isn't a great experience. For example, using the code from the HOWTO on styling inline applications:

Screen.Recording.2024-04-04.at.12.29.29.mov
@davep davep changed the title Inline mode and the command palette don't play well togather Inline mode and the command palette don't play well together Apr 4, 2024
TomJGooding added a commit to TomJGooding/pypi-search-tui that referenced this issue Apr 4, 2024
This app (currently) doesn't utilise the command palette anyway, and
it doesn't play nicely with inline mode as of Textual v0.55.1
(see Textualize/textual#4385)
@davep davep added the bug Something isn't working label Apr 4, 2024
Copy link

github-actions bot commented Apr 6, 2024

Don't forget to star the repository!

Follow @textualizeio for Textual updates.

@TomJGooding
Copy link
Contributor

I've just tested this with the same demo on v0.56.0 just released, while it definitely now looks better than Dave's recording, I'm afraid the command palette will flicker when the clock is updated:

command-palette-flicker.mp4

Copy link

github-actions bot commented Apr 7, 2024

Don't forget to star the repository!

Follow @textualizeio for Textual updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants