-
Notifications
You must be signed in to change notification settings - Fork 764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tree.select_node
doesn't select the node, it highlights it
#4660
Comments
The docs do say that this will only "move the cursor to the given node", but the method name is perhaps a bit confusing. |
True - I think the problem is we're confusing the naming since we have a message called I think renaming this to something like |
FYI, DataTable carefully delineates hovering, moving, and selecting. It sounds like it would be good to make the breaking change to rename the message or change its meaning. |
Opened a PR for this in #4753.
|
Don't forget to star the repository! Follow @textualizeio for Textual updates. |
The Tree message names make a distinction between highlighting a node and selecting a node.
This method name strongly suggests it'll select a node, but in reality it only highlights it (moves the cursor to a node).
I'd suggest renaming to something like
move_cursor(node)
.The text was updated successfully, but these errors were encountered: