Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not ugly #1413

Merged
merged 3 commits into from
Dec 20, 2022
Merged

Not ugly #1413

merged 3 commits into from
Dec 20, 2022

Conversation

willmcgugan
Copy link
Collaborator

@willmcgugan willmcgugan commented Dec 20, 2022 •
edited
Loading

Header is now neutral in color
Screenshot 2022-12-20 at 14 14 18
Screenshot 2022-12-20 at 14 14 13

darrenburns
darrenburns approved these changes Dec 20, 2022
View reviewed changes
Copy link
Member

@darrenburns darrenburns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initially rejected as I thought the revert of the stuff from earlier was a mistake and didn't see the comment about it in the PR description.
Looks much better to me.

@willmcgugan willmcgugan merged commit dd2b89b into main Dec 20, 2022
@willmcgugan willmcgugan deleted the not-ugly branch December 20, 2022 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darrenburns darrenburns darrenburns approved these changes

@davep davep Awaiting requested review from davep

@rodrigogiraoserrao rodrigogiraoserrao Awaiting requested review from rodrigogiraoserrao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Header color is close to the ugliest color in the world
2 participants
@willmcgugan @darrenburns