Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Markdown improvements #2803

Merged
merged 14 commits into from
Jun 20, 2023
Merged

Markdown improvements #2803

merged 14 commits into from
Jun 20, 2023

Commits on Jun 19, 2023

  1. Initial set of Markdown widget unit tests 

    Noting too crazy or clever to start with, initially something to just test
the basics and to ensure that the resulting Textual node list is what we'd
expect.

Really just the start of a testing framework for Markdown.
    @davep
    davep committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    50ff6b0 View commit details
    Browse the repository at this point in the history

  2. Allow handling of an unknown token 

    This allow for a couple of things:

1. First and foremost this will let me test for unhandled tokens in testing.
2. This will also let applications support other token types.
    @davep
    davep committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    d1d1b71 View commit details
    Browse the repository at this point in the history

  3. Update the Markdown testing to get upset about unknown token types

    @davep
    davep committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    90696ca View commit details
    Browse the repository at this point in the history

  4. Treat a code_block markdown token the same as a fence 

    I believe this should be a fine way to solve this. I don't see anything that
means that a `code_block` is in any way different than a fenced block that
has no syntax specified.

See Textualize#2781.
    @davep
    davep committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    89e25ce View commit details
    Browse the repository at this point in the history

  5. Add a test for a code_block within Markdown

    @davep
    davep committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    18f4656 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into markdown-improvements

    @davep
    davep committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    7d732eb View commit details
    Browse the repository at this point in the history

  7. Allow for inline fenced code and code blocks 

    See Textualize#2676

Co-authored-by: TomJGooding <101601846+TomJGooding@users.noreply.github.com>
    @davep @TomJGooding
    davep and TomJGooding committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    e2dd711 View commit details
    Browse the repository at this point in the history

  8. Update the ChangeLog

    @davep
    davep committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    8ef5ab1 View commit details
    Browse the repository at this point in the history

  9. Improve the external Markdown elements are added to the document

    @davep
    davep committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    4986737 View commit details
    Browse the repository at this point in the history

  10. Improve the testing of Markdown 

    Also add a test for the list inline code block
    @davep
    davep committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    9fcb4d4 View commit details
    Browse the repository at this point in the history

  11. Remove the unnecessary pause

    @davep
    davep committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    870b6c3 View commit details
    Browse the repository at this point in the history

  12. Stop list items in Markdown being added to the focus chain 

    See Textualize#2380
    @davep
    davep committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    21558ed View commit details
    Browse the repository at this point in the history

  13. Merge branch 'main' into markdown-improvements

    @davep
    davep committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    3412a28 View commit details
    Browse the repository at this point in the history

  14. Remove hint to pyright/pylance/pylint that it's okay to ignore the arg

    @davep
    davep committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    01e6401 View commit details
    Browse the repository at this point in the history