Allow enabling/disabling tab via tab pane. #3152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows one to use the 'disabled' attribute in tab panes to enable/disable a tab, which is particularly useful if you want to instantiate a tab that starts off as disabled, as seen in #3149.
davep
approved these changes
Aug 23, 2023
| return self.tab_pane | ||
|
|
||
| @dataclass | ||
| class Enabled(Message): |
There was a problem hiding this comment.
Might it not make sense to give this and TabPane.Disabled a common parent class (adds to the utility of @on for example)?
There was a problem hiding this comment.
I'm honestly not fussed either way. I'll add it if you ask for it, otherwise I'll just merge this PR. 🤷
There was a problem hiding this comment.
It feels like it would be more in keeping with where we're slowly heading with multiple messages on a widget (where appropriate); but it sure wasn't a "must do won't approve or else". ;-)
There was a problem hiding this comment.
Point taken. 9ef644c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #3149.