Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate ids #4032

Merged
merged 7 commits into from Jan 23, 2024
Merged

Validate ids #4032

merged 7 commits into from Jan 23, 2024

Conversation

rodrigogiraoserrao
Copy link
Contributor

@rodrigogiraoserrao rodrigogiraoserrao commented Jan 16, 2024 •
edited

Fix #3954.

There was already a check taking place but the regex used was too lenient.

@rodrigogiraoserrao rodrigogiraoserrao marked this pull request as ready for review January 16, 2024 17:56
willmcgugan
willmcgugan reviewed Jan 16, 2024
View reviewed changes
src/textual/dom.py Outdated Show resolved Hide resolved
@willmcgugan willmcgugan merged commit 225fa24 into main Jan 23, 2024
20 checks passed
@willmcgugan willmcgugan deleted the validate-ids branch January 23, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willmcgugan willmcgugan willmcgugan approved these changes

@davep davep Awaiting requested review from davep

@darrenburns darrenburns Awaiting requested review from darrenburns

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

It is possible to give a widget an ID that can't be queried back
2 participants
@rodrigogiraoserrao @willmcgugan