Data binding and more #4075
Data binding and more #4075
Conversation
Co-authored-by: Darren Burns <darrenburns@users.noreply.github.com>
| def set( | ||
| self, | ||
| display: bool | None = None, | ||
| visible: bool | None = None, | ||
| disabled: bool | None = None, | ||
| loading: bool | None = None, | ||
| ) -> DOMQuery[QueryType]: |
There was a problem hiding this comment.
I thought this would take **kwargs and just set whatever keyword argument(s) is/are provided on all of the DOMNodes. Wouldn't that be more helpful than being prescriptive about the specific attributes we can set?
There was a problem hiding this comment.
It's for the benefit of typechecking mainly.
| disabled: bool | None = None, | ||
| loading: bool | None = None, |
There was a problem hiding this comment.
disabled and loading are attributes on widgets, not on DOM nodes. Won't that be a problem? Maybe due to typing issues or inconsistencies?
| yield WorldClock("Europe/Paris").data_bind(WorldClockApp.time) | ||
| yield WorldClock("Asia/Tokyo").data_bind(WorldClockApp.time) | ||
| ``` | ||
|
|
There was a problem hiding this comment.
|
|
||
| Args: | ||
| compose_parent: The node doing the binding. |
There was a problem hiding this comment.
| Args: | |
| compose_parent: The node doing the binding. |
| def make_setter(variable_name: str) -> Callable[[object], None]: | ||
| """Make a setter for the given variable name. | ||
|
|
||
| Args: | ||
| variable_name: Name of variable being set. | ||
|
|
||
| Returns: | ||
| A callable which takes the value to set. | ||
| """ | ||
|
|
||
| def setter(value: object) -> None: | ||
| """Set bound data.""" | ||
| _rich_traceback_omit = True | ||
| Reactive._initialize_object(self) | ||
| setattr(self, variable_name, value) | ||
|
|
||
| return setter |
There was a problem hiding this comment.
Can't this be defined outside of the for loop?
| self.watch( | ||
| compose_parent, | ||
| reactive.name, | ||
| setter, |
There was a problem hiding this comment.
Why not partial(setattr, self, variable_name)?
Bit of a mixed bag. Added a number of things while working on Tailless. The most notable is probably the data binding.
See changelog for details.