fix(selection list): update indexes after option removed #4464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvllmr
reviewed
Apr 30, 2024
darrenburns
reviewed
May 2, 2024
| @@ -646,6 +646,11 @@ def _remove_option(self, index: int) -> None: | |||
| option = self.get_option_at_index(index) | |||
| self._deselect(option.value) | |||
| del self._values[option.value] | |||
| # Decrement index of options after the one we just removed. | |||
There was a problem hiding this comment.
Maybe a separate issue (or not an issue at all if I'm missing something), but this makes me wonder why the highlighted index wouldn't be decremented if it appears below the removed option.
There was a problem hiding this comment.
Actually from a skim, I'm guessing it might be that the highlight is applied based on the ID of the option rather than the index. It's just converted to an ID via a validator.
TomJGooding
deleted the
fix-selection-list-update-indexes-after-option-removed
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4462.
I've added a basic test that the index is updated, but I'm not sure if you need a regression test that actually replicates the issue above?
Please review the following checklist.