Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix select #4499

Merged
merged 10 commits into from
May 11, 2024
Merged

Fix select #4499

merged 10 commits into from
May 11, 2024

Conversation

willmcgugan
Copy link
Collaborator

Fixes #4489

@willmcgugan
Copy link
Collaborator Author

@TomJGooding I think this is the fix...

@TomJGooding
Copy link
Contributor

TomJGooding commented May 9, 2024

Wouldn't this introduce a new issue where the Select would stay expanded if you clicked to focus another widget?

select-expanded.mp4

@willmcgugan
Copy link
Collaborator Author

You're absolutely right. Pushed an alternative fix, which doesn't break hiding the drop down on blur.

@TomJGooding
Copy link
Contributor

TomJGooding commented May 10, 2024

This seems to have done the trick from a quick test!

Just for my own knowledge, is this suppression of the click really only required because the 'overlay' concept doesn't play nicely with how the focus is handled?

@willmcgugan
Copy link
Collaborator Author

Just for my own knowledge, is this suppression of the click really only required because the 'overlay' concept doesn't play nicely with how the focus is handled?

Pretty much. The interaction with click / blur was proving to be difficult to unpick. I suspect it could be done much simpler with pure CSS, but I didn't get that far.

@willmcgugan willmcgugan merged commit 88bc655 into main May 11, 2024
20 checks passed
@willmcgugan willmcgugan deleted the fix-select branch May 11, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clicking Select doesn't properly collapse overlay
2 participants