Allow more easily customisable scrollbar glyphs #4505
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4500
This allows a user to easily customise scrollbar display. For example, when using the Consolas font, scrollbars display poorly:
![cmd_NfNfGUSQfX](https://private-user-images.githubusercontent.com/3398021/329780082-03cfb020-96cd-42d6-b152-b1abac5e7fbf.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjAzMzkzNDEsIm5iZiI6MTcyMDMzOTA0MSwicGF0aCI6Ii8zMzk4MDIxLzMyOTc4MDA4Mi0wM2NmYjAyMC05NmNkLTQyZDYtYjE1Mi1iMWFiYWM1ZTdmYmYucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDcwNyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA3MDdUMDc1NzIxWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9Y2FmMWVlOGU4YjNiZTYwNjBlMTc2OThiMTdlYzBlZmU1M2I2NTFlYTY5NzI2MGU0MzRkNGE0ZmIxM2RiYzIxMSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.CBheeUzfKfqWdEn928kFTes2jY1ZMjIdlkIUUTbWpaI)
By reducing the characters to those supported, the display is more consistent:
By using some lightly shaded characters, the scrollbars gain some flair:
The blank glyph can also be replaced:
This is easier than replacing the entire
ScrollBarRender.render_bar
function.