Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enforce mounting #4547

Merged
merged 3 commits into from
May 23, 2024
Merged

enforce mounting #4547

merged 3 commits into from
May 23, 2024

Conversation

willmcgugan
Copy link
Collaborator

@willmcgugan willmcgugan commented May 23, 2024 •
edited
Loading

Raises a MountError if you try to mount a widget on to something that is not yet mounted.

Should catch misunderstandings about the DOM.

Fixed #4532

@willmcgugan willmcgugan merged commit 6034065 into main May 23, 2024
20 checks passed
@willmcgugan willmcgugan deleted the check-mount branch May 23, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darrenburns darrenburns darrenburns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prevent mounting on unmounted widgets
2 participants
@willmcgugan @darrenburns