Basic text input #495

darrenburns · 2022-05-11T09:30:51Z

Goals for this PR

Non-goals

Multiline input - I will implement a very naive basic multiline edit feature to help with modelling the API etc, but my goal is not to deliver a polished multiline input widget.
Efficiency of text storage - no piece tables, ropes, etc. to see here :) with the focus being on single line here, it doesn't make sense. The text storage will be a simple string, but abstracted away into a class to make it easier to swap out going forward.
Clicking somewhere makes the cursor go to that location - not MVP, will reserve this for later

darrenburns · 2022-05-11T09:32:09Z

src/textual/widgets/text_input.py

+from textual.widget import Widget
+
+
+class TextInputBase(Widget):


Trying to think ahead a little here by extracting some common keybinding/text navigation stuff into a base class. Not sure if it will work out, but that's my thinking.

src/textual/widgets/text_input.py

…input

darrenburns · 2022-05-17T12:58:44Z

Having some problems with Text wrapping where typing multiple words separated by spaces can sometimes cause the second word to disappear. I'm assuming it's folding on to the next line. Have tried playing with overflow and no_wrap but no luck

olivierphi

Amazing work! 😮
I just have a few very picky comments on things that don't matter, that you're totally free to ignore :-)

src/textual/_text_backend.py

src/textual/_timer.py

src/textual/keys.py

src/textual/widgets/text_input.py

olivierphi · 2022-05-17T13:01:03Z

src/textual/widgets/text_input.py

+    def get_content_height(
+        self, container_size: Size, viewport_size: Size, width: int
+    ) -> int:
+        return self._editor.content.count("\n") + 1 + 2


could be nice to add a quick comment that explains why we add 1 and 2 ? :-)

Aha, but that assumes that I know why I added 1 and 2! ;)

Going to leave this for now since it's just for my naive/hacky little multiline editor thing, not intended to be production ready really :)

willmcgugan

I like the direction this is going.

Haven't been too pedantic re docstrings etc. since I know this is the first part of a feature branch.

src/textual/widgets/text_input.py

src/textual/keys.py

src/textual/widgets/text_input.py

olivierphi · 2022-05-17T16:08:45Z

src/textual/keys.py

@@ -200,6 +200,9 @@ class Keys(str, Enum):
    ShiftControlEnd = ControlShiftEnd


+KEY_BINDINGS = Keys._value2member_map_.values()


darrenburns · 2022-05-18T09:57:18Z

@willmcgugan I've fixed the issue where scrolling would break on resize (since the "visible window" into the editor content wasn't being adjusted previously), and also I had missed a no_wrap on the placeholder text in one case.

text-input-1

0674f50

darrenburns commented May 11, 2022

View reviewed changes

src/textual/widgets/text_input.py Outdated Show resolved Hide resolved