ASCellNode accessibility labels not being read correctly #1997
Labels
Comments
|
I can confirm that if you comment out the change #1941 that ASCellNode the accessibilityLabel property is read correctly, however with the change in place the label is ignored. |
bdolman
added a commit
to Hitlabs/Texture
that referenced
this issue
Apr 18, 2022
This is a partial revert of TextureGroup#1941 The change in TextureGroup#1941 has caused some issues for us and others (see TextureGroup#1997). If I set `myNode.isAccessibilityElement = true,` then what ends up happening is that the table cell wrapper view (_ASTableViewCell) also has `isAccessibilityElement = true`. But then when iOS goes through the hierarchy it identifies the table cell wrapper view as the target and attempts to use that accessibilityLabel, which doesn't exist (because it's actually on the nested node view). So our node's label is never used. I'm not sure why setting `isAccessibilityElement` in `_ASTableViewCell` was necessary in TextureGroup#1941 in order to make a node non-accessible, since the default value is already false.
rcasula
pushed a commit
to openbitapp/Texture
that referenced
this issue
Dec 12, 2023
This is a partial revert of TextureGroup#1941 The change in TextureGroup#1941 has caused some issues for us and others (see TextureGroup#1997). If I set `myNode.isAccessibilityElement = true,` then what ends up happening is that the table cell wrapper view (_ASTableViewCell) also has `isAccessibilityElement = true`. But then when iOS goes through the hierarchy it identifies the table cell wrapper view as the target and attempts to use that accessibilityLabel, which doesn't exist (because it's actually on the nested node view). So our node's label is never used. I'm not sure why setting `isAccessibilityElement` in `_ASTableViewCell` was necessary in TextureGroup#1941 in order to make a node non-accessible, since the default value is already false.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We recently updated to the latest code from master and got a couple of reports from users that VoiceOver is no longer correctly reading out labels for various cells within the app. Returning back to our older version it works fine. It looks like if I comment out the change from #1941 the labels are read out correctly once more.
I found a couple of cases of similar behavior in the Pinterest app but not sure if these views use ASTableNode specifically on the "Add account" screen nothing is read out aside from a couple of Button traits.
cc @garrettmoon @bolsinga Just in case you're able to replicate and confirm the same behavior on the Pinterest side.
The text was updated successfully, but these errors were encountered: