Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IGListAdapter+AsyncDisplayKit.h not found #254

Closed
huangboju opened this issue May 10, 2017 · 6 comments
Closed

IGListAdapter+AsyncDisplayKit.h not found #254

huangboju opened this issue May 10, 2017 · 6 comments

Comments

@huangboju
Copy link

huangboju commented May 10, 2017

I installed with carthage
IGListAdapter+AsyncDisplayKit.h not found
Xcode: 8.2.1
Carthage: 0.18.1
Language:Swift

but version 2.2 is ok

@garrettmoon
Copy link
Member

@huangboju can you upload a sample project and add some repro steps? Thanks!

@huangboju
Copy link
Author

@garrettmoon this is Demo

@rainypixels
Copy link
Contributor

@garrettmoon Apologies if I filed a dupe. I added a demo project as well in #265.

@garrettmoon
Copy link
Member

Ok, so I think I understand the issue now. Essentially, when AsyncDisplayKit is built, it's built without IGListKitSupport because __has_include(<IGListKit/IGListKit.h>) evaluates to false. However, when you try and build the app, it evaluates to true and the import isn't there. I'm not sure Carthage supports a good way to specify build flags when compiling frameworks (my Googles lead to nothing) but it does seem that Carthage is philosophically opposed to the idea of 'subspecs': Carthage/Carthage#588

I think this means, to support IGListKit with Carthage we'd need to build it in by default for everyone. I'm opposed to this because I don't think the audience is large enough compared to something like PINRemoteImage (which is built in by default for Carthage users).

So I think sadly this may be a limitation of Carthage :(

It might be possible to create separate schemes for IGListKit which would always be built but then you could just drag that in? I'd be open to a pull request that adds support for that, but it seems like a workaround to something Carthage opposes :/

@rainypixels
Copy link
Contributor

@garrettmoon Thanks for looking into it. Yeah, I'm definitely seeing philosophical opposition to subspecs as well, so I'm not sure a workaround using schemes makes much sense here...

Oh, well. 😢

@nguyenhuy
Copy link
Member

I'm gonna close this issue because it seems that there is nothing else we can do here. Feel free to reopen otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants