Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reclaim CALayer asyncTransactions, use pointer-based NSMutableSet instead #1510

Merged
merged 1 commit into from May 10, 2019

Conversation

Adlai-Holler
Copy link
Member

Scrolling down to the end of a feed (~100 items) on my iPad this data had:

Before: 310KB, all persistent

Screen Shot 2019-05-10 at 11 58 11 AM

After: 110KB, all transient

Screen Shot 2019-05-10 at 11 52 26 AM

Copy link
Contributor

@mikezucc mikezucc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, was seeing this leak as well over here 👍

@Adlai-Holler Adlai-Holler merged commit 27fe219 into master May 10, 2019
@Adlai-Holler Adlai-Holler deleted the AHReclaimTransactions branch May 10, 2019 23:31
@bolsinga
Copy link
Contributor

bolsinga commented May 11, 2019

Super! Was this researched as part of #1505?

@Adlai-Holler
Copy link
Member Author

it must’ve played a role!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants