tests for ASImageNode dynamic tint color
#1644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vovasty
force-pushed
the
dynamic-tint-test
branch
from
d9a40fb
to
c5aa1b2
Compare
rahul-malik
reviewed
Aug 26, 2019
| @@ -11,6 +11,18 @@ | |||
|
|
|||
| #import <AsyncDisplayKit/AsyncDisplayKit.h> | |||
|
|
|||
| #if AS_AT_LEAST_IOS13 | |||
There was a problem hiding this comment.
I don't see why this method would need to be only used in iOS13+ only, is there a particular reason this is guarded?
There was a problem hiding this comment.
dynamic color is only available for ios13
rahul-malik
approved these changes
Aug 27, 2019
Tests/ASImageNodeSnapshotTests.mm
Outdated
|
|
||
| UIImage *image = makeImageWithColor(UIColor.redColor, CGSize{.width = 100, .height = 100}); | ||
| image = [image imageWithRenderingMode:UIImageRenderingModeAlwaysTemplate]; | ||
| UIColor* tintColor = [UIColor colorWithDynamicProvider:^UIColor * _Nonnull(UITraitCollection * _Nonnull traitCollection) { |
There was a problem hiding this comment.
I'm not sure if creating the color variants manually is helpful for debugging but if we just want a white/black color I would recommend [UIColor systemBackgroundColor]
vovasty
force-pushed
the
dynamic-tint-test
branch
3 times, most recently
from
f813c33
to
e6ba4de
Compare
rahul-malik
approved these changes
Aug 29, 2019
|
@vovasty - It seems you will either need to add new tests that aren't under iOS 13 or add the define check to overcome this issue /Users/runner/runners/2.157.0/work/Texture/Texture/Tests/ASImageNodeSnapshotTests.mm:14:17: unused function 'makeImageWithColor' [-Werror,-Wunused-function]
static UIImage* makeImageWithColor(UIColor *color, CGSize size) { ❌ |
vovasty
force-pushed
the
dynamic-tint-test
branch
from
e6ba4de
to
8c03d6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no logic changes, just missing tests.