Defer image asset regeneration to draw loop #1663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bolsinga
reviewed
Sep 6, 2019
bolsinga
approved these changes
Sep 6, 2019
rahul-malik
approved these changes
Sep 6, 2019
bolsinga
approved these changes
Sep 6, 2019
bdolman
added a commit
to Hitlabs/Texture
that referenced
this pull request
Nov 24, 2021
Before this change, the image asset (which may contain multiple reps of an image for differing traits) was only consulted when the trait collection changed. But in cases where display was scheduled on the node and the trait collection had not changed, the image node ends up with the default representation instead. An example of this: You have an image asset with two versions: light (default) and dark. The device is currently in dark mode The image is being presented in an item in a collection node. 1. Item node is first added to hierarchy. Trait collection doesn't match so regenerateFromImageAsset=true. 2. Dark image is rendered, as expected 3. Item node is scrolled off screen 4. Item is scrolled back on screen 5. This triggers display on the item node 6. Trait collection has NOT changed so regenerateFromImageAsset=false 7. So, imageAsset is not consulted and default (Light) image is rendered After looking at this a lot, I don’t see any reason why we need the regenerateFromImageAsset flag at all (introduced in TextureGroup#1663). Whenever the image node is displayed we need to make sure we are generating the correct representation.
bdolman
added a commit
to Hitlabs/Texture
that referenced
this pull request
Nov 24, 2021
Before this change, the image asset (which may contain multiple reps of an image for differing traits) was only consulted when the trait collection changed. But in cases where display was scheduled on the node and the trait collection had not changed, the image node ends up with the default representation instead. An example of this: You have an image asset with two versions: light (default) and dark. The device is currently in dark mode The image is being presented in an item in a collection node. 1. Item node is first added to hierarchy. Trait collection doesn't match so regenerateFromImageAsset=true. 2. Dark image is rendered, as expected 3. Item node is scrolled off screen 4. Item is scrolled back on screen 5. This triggers display on the item node 6. Trait collection has NOT changed so regenerateFromImageAsset=false 7. So, imageAsset is not consulted and default (Light) image is rendered After looking at this a lot, I don’t see any reason why we need the regenerateFromImageAsset flag at all (introduced in TextureGroup#1663). Whenever the image node is displayed we need to make sure we are generating the correct representation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a potential dealloc race condition that can occur when attempting to perform work with image asset out of the main thread. Moving that work into the image node draw loop if necessary