Use queue in ASMainSerialQueue
#1738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For removing the first element, time complexity of `NSMutableArray` is O(n) while `queue` is O(1), which is more efficient.
hanton
force-pushed
the
use-queue-ASMainSerialQueue
branch
from
34a754c
to
a8a8835
Compare
rahul-malik
approved these changes
Dec 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the original implementation, when removing the first element of an array, we use the
NSMutableArray'sremoveObjectAtIndexmethod, which means to remove a single item, every object in the array is shifted down one, it isO(n)time complexity.The PR proposes to use
queue, which isO(1)when removing the first element, it is more efficient.