NoCopyRendering experiment: Fix possible memory leak if image node rendering is canceled #trivial #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adlai-Holler
requested review from
maicki,
garrettmoon,
appleguy and
nguyenhuy
Generated by 🚫 Danger |
appleguy
approved these changes
Jan 23, 2018
Adlai-Holler
changed the title
Adlai-Holler
added a commit
that referenced
this pull request
Jan 23, 2018
…ndering is canceled #trivial (#765) * Fix memory leak if image node rendering is canceled * Update comment
bernieperez
pushed a commit
to AtomTickets/Texture
that referenced
this pull request
Apr 25, 2018
…ndering is canceled #trivial (TextureGroup#765) * Fix memory leak if image node rendering is canceled * Update comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because I forgot to replace this
UIGraphicsEndImageContextcall with itsASGraphicsversion, if you have the experiment enabled and this branch is taken then the image buffer will not be freed.