Update IGListKit dependency to allow for updated versions #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maicki
approved these changes
Feb 13, 2018
There was a problem hiding this comment.
@johntmcintosh Thanks for updating! LGTM, but refer to @Adlai-Holler for the last call.
Adlai-Holler
approved these changes
Feb 13, 2018
There was a problem hiding this comment.
This is reasonable, although we may need to restrict it again if incompatibilities crop up. Thanks @johntmcintosh!
bernieperez
pushed a commit
to AtomTickets/Texture
that referenced
this pull request
Apr 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IGListKit subspec currently has the dependency hardcoded to version
3.0.0. I've come across a need to use a later version of IGListKit, so in the process I thought it would be nice for the podspec to allow a little more flexibility in versioning of the dependency. This PR will default to the latest 3.x version, but would also allow consumers to override the IGListKit dependency in their Podfiles to be anything in the 3.x.x range.