Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added JqGrid groupingView including example #118

Closed
wants to merge 7 commits into from

Conversation

webdevilopers
Copy link
Contributor

Fixes issue #108

JqGrid groupingView example URL:
http://YOUR-PROJECT//zfcDatagrid/jqgrid/groupingview

This PR will not add groupingView as a new feature itself. It simply adds an example that shows how to set groupingView to an individual layout.

The example is based on the JqGrid demo:
http://trirand.com/blog/jqgrid/jqgrid.html - Grouping - Grouping row(s) collapsed

The important part is the Renderer that has been changed in order to allow sorting when using groupingView.

There are some differences in the behaviour of the ZfcDatagrid example and the JqGrid example when you use sorting Inv No or Date. But this should be checked later since it is no "bug".

@webdevilopers
Copy link
Contributor Author

@ThaDafinser Can you explain what the FAIL means? Is there an conflict between my and other commits?

@ThaDafinser
Copy link
Owner

@webdevilopers its because of the psr-2 standard, see here:
https://travis-ci.org/ThaDafinser/ZfcDatagrid/jobs/27767005#L140

Can you fix this maybe? You do it with this tool: fabpot/php-cs-fixer

@webdevilopers
Copy link
Contributor Author

I'm beginning to understand what this Travis thing is actually about.
I will check it out in the next weeks and fix it, @ThaDafinser !

@ThaDafinser
Copy link
Owner

@webdevilopers i started with Travis also with this project.
It's just amazing.

The PSR-2 thing i started some time ago ....a lot of benefits:

  • no different formatting anymore
  • better diffs
  • ...

@webdevilopers
Copy link
Contributor Author

I will wait for #97 .

@ThaDafinser
Copy link
Owner

Like already thought in the other PR, i think it would not be good to only include such a feature for one renderer.

At least the export renderer would need to be able to achieve the same.

If you have an idea how we can achieve this, feel free to reopen this PR

@ThaDafinser ThaDafinser closed this Aug 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants