Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace axios with ky #6

Closed
0xbe1 opened this issue Oct 31, 2023 · 0 comments
Closed

refactor: replace axios with ky #6

0xbe1 opened this issue Oct 31, 2023 · 0 comments

Comments

@0xbe1
Copy link
Contributor

0xbe1 commented Oct 31, 2023

As KY author said in https://twitter.com/sindresorhus/status/1037763588826398720:

Yes. Axios is based on XMLHttpRequests, while Ky is based on Fetch. Axios has manually implemented a lot of things we get for free with Fetch. Fetch-based libs should be more stable and less buggy in general. Ky also has retry functionality.

for us, ky is desired because:

so that we can get rid of:

  • retryLimit in PoolDataClient.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants