Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Symmetric support #8

Merged
merged 15 commits into from
Oct 3, 2018
Merged

Symmetric support #8

merged 15 commits into from
Oct 3, 2018

Commits on Oct 3, 2018

  1. Implement cipher.Block for AES and DES3 

    re #6
    Richard Kettlewell authored and Richard Kettlewell committed Oct 3, 2018
    Configuration menu
    Copy the full SHA
    163e0f1 View commit details
    Browse the repository at this point in the history

  2. Fast CBC support 

    re #6
    Richard Kettlewell authored and Richard Kettlewell committed Oct 3, 2018
    Configuration menu
    Copy the full SHA
    5ffcf58 View commit details
    Browse the repository at this point in the history

  3. Exercise GCM in tests 

    re #6
    Richard Kettlewell authored and Richard Kettlewell committed Oct 3, 2018
    Configuration menu
    Copy the full SHA
    227df68 View commit details
    Browse the repository at this point in the history

  4. HSM-native GCM 

    For testing with SoftHSM2 you need at least version 2.4.0, i.e. at least
Debian buster/sid or Ubuntu cosmic (or BYO).

This commit also updates our dependency on github.com/miekg/pkcs11 to
one with GCM support.

re #6
    Richard Kettlewell authored and Richard Kettlewell committed Oct 3, 2018
    Configuration menu
    Copy the full SHA
    9ea5798 View commit details
    Browse the repository at this point in the history

  5. HMAC implementation 

    re #7
    Richard Kettlewell authored and Richard Kettlewell committed Oct 3, 2018
    Configuration menu
    Copy the full SHA
    60813c5 View commit details
    Browse the repository at this point in the history

  6. Finalized symmetric crypto interface 

    You can now have a crypto11.BlockModeCloser, and must call Close(),
or a cipher.BlockMode, but it has a finalizer.

re #6
    Richard Kettlewell authored and Richard Kettlewell committed Oct 3, 2018
    Configuration menu
    Copy the full SHA
    15ff8ec View commit details
    Browse the repository at this point in the history

  7. Expose CBC via cipher.AEAD 

    This is rather an abuse of the cipher.AEAD interface as the name
and description both indicate it provides authenticated encryption,
which is not the case for CBC. The risk of using it in a context
where authentication is required is mitigated only by documentation.

re #6
    Richard Kettlewell authored and Richard Kettlewell committed Oct 3, 2018
    Configuration menu
    Copy the full SHA
    851d862 View commit details
    Browse the repository at this point in the history

  8. Linter-driven cleanup

    Richard Kettlewell authored and Richard Kettlewell committed Oct 3, 2018
    Configuration menu
    Copy the full SHA
    4585ede View commit details
    Browse the repository at this point in the history

  9. Split symmetric support into separate files 

    re #6 re #7
    Richard Kettlewell authored and Richard Kettlewell committed Oct 3, 2018
    Configuration menu
    Copy the full SHA
    1479211 View commit details
    Browse the repository at this point in the history

  10. Documentation review 

    re #6
    Richard Kettlewell authored and Richard Kettlewell committed Oct 3, 2018
    Configuration menu
    Copy the full SHA
    316d26c View commit details
    Browse the repository at this point in the history

  11. Keep blockModeCloser alive during PKCS#11 calls 

    re #6
    Richard Kettlewell authored and Richard Kettlewell committed Oct 3, 2018
    Configuration menu
    Copy the full SHA
    90391bc View commit details
    Browse the repository at this point in the history

  12. Implement HMAC Reset() and make Sum() friendlier 

    re #7
    Richard Kettlewell authored and Richard Kettlewell committed Oct 3, 2018
    Configuration menu
    Copy the full SHA
    557645c View commit details
    Browse the repository at this point in the history

  13. HMAC empty inputs without panicing 

    re #7
    Richard Kettlewell authored and Richard Kettlewell committed Oct 3, 2018
    Configuration menu
    Copy the full SHA
    b661a57 View commit details
    Browse the repository at this point in the history

  14. update Gopkg.lock 

    We depend upon miekg/pkcs11#82.
    Richard Kettlewell authored and Richard Kettlewell committed Oct 3, 2018
    Configuration menu
    Copy the full SHA
    4409d84 View commit details
    Browse the repository at this point in the history

  15. Query GCM capability rather than provider

    Richard Kettlewell authored and Richard Kettlewell committed Oct 3, 2018
    Configuration menu
    Copy the full SHA
    b92a2ba View commit details
    Browse the repository at this point in the history