Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Origin/misc performance improvements #40

Merged

Conversation

Jie-F
Copy link
Contributor

@Jie-F Jie-F commented Feb 12, 2024

Addresses issues
#36, #37, #38, #39

These changes have been thoroughly tested

  • Replaces np functions with math functions which are faster for scalar inputs
  • Use modulo to improve wrapping
  • Optimized culling
  • Use math.radians and math.degrees consistently, and removed manual angle conversion calculations
  • Optimized circle collision calcs

Additionally, added slight changes to the mine 0 dist fix (issue #35) to clean up code, and make limiting behavior of dist approaching 0 equal to when dist == 0, at least in terms of the speed given to the asteroid

Addresses minor bug #46

@Jie-F
Copy link
Contributor Author

Jie-F commented Feb 14, 2024

Added fix for bug #45

@Jie-F
Copy link
Contributor Author

Jie-F commented Feb 26, 2024

Added fix for issue #47

Copy link
Contributor

@TimArnettThales TimArnettThales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All look good to me.

@TimArnettThales TimArnettThales merged commit 1af13d3 into ThalesGroup:main Mar 7, 2024
1 check passed
@Jie-F Jie-F deleted the origin/misc-performance-improvements branch March 8, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants