generated from ThalesGroup/template-project
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Origin/misc performance improvements #40
Merged
TimArnettThales
merged 28 commits into
ThalesGroup:main
from
Jie-F:origin/misc-performance-improvements
Mar 7, 2024
Merged
Origin/misc performance improvements #40
TimArnettThales
merged 28 commits into
ThalesGroup:main
from
Jie-F:origin/misc-performance-improvements
Mar 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Numpy's functions are optimized for numpy arrays, but are slower than math functions for scalars
….com/Jie-F/kessler-game into origin/misc-performance-improvements
Added fix for bug #45 |
Added fix for issue #47 |
This is so the asteroid will get the ship's velocity passed to it, now that the ship's velocity gets reset upon destruction immediately
TimArnettThales
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All look good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issues
#36, #37, #38, #39
These changes have been thoroughly tested
Additionally, added slight changes to the mine 0 dist fix (issue #35) to clean up code, and make limiting behavior of dist approaching 0 equal to when dist == 0, at least in terms of the speed given to the asteroid
Addresses minor bug #46