Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement searching to regular songs #3

Closed
ThatGuyJacobee opened this issue Aug 24, 2023 · 2 comments
Closed

Implement searching to regular songs #3

ThatGuyJacobee opened this issue Aug 24, 2023 · 2 comments
Labels
Enhancement Requesting a new feature or changes.

Comments

@ThatGuyJacobee
Copy link
Owner

Similarly to how it is implemented in the new /plex command, improve the /play command to include searching if multiple search results are found for a song. In a scenario like this, a search embed will be returned with a menu to allow the user to pick their specific choice. Otherwise, if there is only one result, play the song directly without the search stuff.

Alternatively, another option is to create a separate /search command which allows the user to search for a query and similarly receive a response via an embed and menu. The benefit of this solution is that when running /play it is very likely that most search queries will have more than one search result. Thus a change in directly adding search to that command would make it inconvenient for users who simply want to enter a query and play. This links to #2 issue.

@ThatGuyJacobee ThatGuyJacobee added the Enhancement Requesting a new feature or changes. label Aug 24, 2023
@ThatGuyJacobee
Copy link
Owner Author

This is currently in development, will be released likely tomorrow or within the next few days with the v1.3 release.

ThatGuyJacobee added a commit that referenced this issue Sep 22, 2023
+ Play searching for the regular command has been implemented (#3).
+ Fixed a bunch of incorrect references via process.env.item to using the new client.config.item which enables default values in the case of non-complience.
+ Added .env file versioning, to ensure that the user is alerted when they use a new bot version, but use a legacy config version, to prevent missing out on new features and changes.
+ Docker support, including via docker image and docker-compose.yml has been included this update (#5). See the docker hub image: https://hub.docker.com/r/thatguyjacobee/elitemusic
+ Deprecation of GUILD_ID and OWNER_ID options from the environment file.
ThatGuyJacobee added a commit that referenced this issue Sep 22, 2023
+ Play searching for the regular command has been implemented (#3).
+ Fixed a bunch of incorrect references via process.env.item to using the new client.config.item which enables default values in the case of non-complience.
+ Added .env file versioning, to ensure that the user is alerted when they use a new bot version, but use a legacy config version, to prevent missing out on new features and changes.
+ Docker support, including via docker image and docker-compose.yml has been included this update (#5). See the docker hub image: https://hub.docker.com/r/thatguyjacobee/elitemusic
+ Deprecation of GUILD_ID and OWNER_ID options from the environment file.
@ThatGuyJacobee
Copy link
Owner Author

Completed with v1.3 release! f63c1a3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Requesting a new feature or changes.
Projects
None yet
Development

No branches or pull requests

1 participant