Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve code quality (modularity/functions) #4

Open
ThatGuyJacobee opened this issue Sep 16, 2023 · 0 comments
Open

Improve code quality (modularity/functions) #4

ThatGuyJacobee opened this issue Sep 16, 2023 · 0 comments
Labels
Code Improvements Improve the code for a range of benefits including readability, modularity and robustness. Improvement Requesting changes to an exsiting feature.

Comments

@ThatGuyJacobee
Copy link
Owner

Many parts of the code are quite repetitive, which makes it ideal to change these parts of code into singular functions to reduce code size and improve the overall code quality. Examples include items such as creating a new node queue, embeds (both track & playlist) and more...
@ThatGuyJacobee ThatGuyJacobee added the Improvement Requesting changes to an exsiting feature. label Sep 16, 2023
@ThatGuyJacobee ThatGuyJacobee added the Code Improvements Improve the code for a range of benefits including readability, modularity and robustness. label Oct 2, 2023
ThatGuyJacobee added a commit that referenced this issue May 13, 2024
@ThatGuyJacobee
(v1.5) Code refactoring, Plex playnext cmd & bug fixes
c14f8e2 
+ Refactored code relating to searching and playing songs. This relates to both the regular system and via Plex optional feature.
+ Estimated code reduction of around 40%~ for play/search related commands versus v1.4 build.
+ New sharedFunctions.js utils file which houses new functions relating to searching and playing songs (relates to the general #4 goal).
+ Added a new /plex playnext command which functions similarly to the regular playnext command, but for the Plex feature (#52).
+ Adjusted the API endpoints that are used for Plex server requests, to more reliable and valid options.
+ Fixed bug #53 by encoding the query into a URI component for any web requests.
+ Bug #32 should be resolved after reworking code into functions and switching to a different endpoint for searching.
+ Config version remains unchanged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Code Improvements Improve the code for a range of benefits including readability, modularity and robustness. Improvement Requesting changes to an exsiting feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ThatGuyJacobee