Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major code changes #4

Open
wants to merge 2 commits into
base: feat/movement-api
Choose a base branch
from

Conversation

brainsynder-Dev
Copy link

Adds:

  • moveTo method
  • teleportPlayer method
  • movehere subcommand
  • tphere subcommand

Changes:

  • restructured the code for multiversion support

@Thatsmusic99 Thatsmusic99 self-requested a review March 24, 2022 10:08
@Thatsmusic99 Thatsmusic99 changed the base branch from master to feat/movement-api March 24, 2022 10:09
@Thatsmusic99
Copy link
Owner

I've moved this into a separate branch for the time being since I've already got pending changes in other branches that may need to be tailored to these large changes too, once I believe both are ready I'll merge them into the main branch.

protected void playEntityOnFireExtinguishedSound() {}

/**
* These methods prevent pets from being saved in the worlds
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lul


@Override
public boolean isOnPortalCooldown() {
return true; // Prevents mob from teleporting from a portal
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can always change this in the future, I do want to emulate a player as much as possible with this.

Copy link
Owner

@Thatsmusic99 Thatsmusic99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good, just want to ask about naming conventions in one place and I should be fine merging this.

}


private Path fixThisStupidThing() {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting naming, may I ask what this and alsoFixThis do?

return true;
}

if (args[0].equalsIgnoreCase("command")) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Command management regarding this shall be changed in a separate branch, so don't worry about doing too much with it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants