Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/workflow config file #158

Merged
merged 7 commits into from
May 28, 2023
Merged

Feature/workflow config file #158

merged 7 commits into from
May 28, 2023

Conversation

jdddog
Copy link
Contributor

@jdddog jdddog commented Feb 27, 2023

No description provided.

@jdddog jdddog force-pushed the feature/workflow-config-file branch from 5afb12e to 978afb1 Compare March 28, 2023 05:03
@jdddog jdddog force-pushed the feature/workflow-config-file branch from 8b5679c to 72007f4 Compare April 18, 2023 05:11
@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Patch coverage: 94.43% and project coverage change: -0.92 ⚠️

Comparison is base (2a46d69) 96.93% compared to head (f4bf6ee) 96.01%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #158      +/-   ##
===========================================
- Coverage    96.93%   96.01%   -0.92%     
===========================================
  Files           30       19      -11     
  Lines         4468     4621     +153     
  Branches       601      615      +14     
===========================================
+ Hits          4331     4437     +106     
- Misses          68      111      +43     
- Partials        69       73       +4     
Impacted Files Coverage Δ
academic_observatory_workflows/clearbit.py 85.71% <ø> (ø)
...rvatory_workflows/workflows/unpaywall_telescope.py 97.93% <ø> (-2.07%) ⬇️
...ry_workflows/workflows/web_of_science_telescope.py 100.00% <ø> (ø)
academic_observatory_workflows/config.py 91.17% <87.50%> (-8.83%) ⬇️
...y_workflows/workflows/crossref_events_telescope.py 87.82% <88.54%> (-9.80%) ⬇️
...c_observatory_workflows/workflows/ror_telescope.py 92.57% <93.80%> (-5.77%) ⬇️
...ervatory_workflows/workflows/openalex_telescope.py 95.18% <94.83%> (-1.31%) ⬇️
..._workflows/workflows/crossref_fundref_telescope.py 93.37% <96.22%> (+2.00%) ⬆️
...ic_observatory_workflows/workflows/doi_workflow.py 96.88% <97.18%> (+1.21%) ⬆️
...observatory_workflows/workflows/oa_web_workflow.py 96.05% <98.14%> (+0.25%) ⬆️
... and 6 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jdddog jdddog force-pushed the feature/workflow-config-file branch from 9cc67ab to 2e4e2f4 Compare May 17, 2023 23:53
@jdddog jdddog requested a review from keegansmith21 May 18, 2023 20:40
Copy link
Contributor

@keegansmith21 keegansmith21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank Jamie, the changes all look really good. Just a few very minor comments that would be good to take a look at before merging.

@jdddog jdddog marked this pull request as ready for review May 26, 2023 04:09
@jdddog
Copy link
Contributor Author

jdddog commented May 26, 2023

Thank Jamie, the changes all look really good. Just a few very minor comments that would be good to take a look at before merging.

Thanks for your review Keegan, I've made most of the changes apart from the DOI query / dummy task ones.

keegansmith21
keegansmith21 previously approved these changes May 26, 2023
Copy link
Contributor

@keegansmith21 keegansmith21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into the suggestions. Looks really good, Jamie 👍

@jdddog jdddog merged commit 0fe99f3 into develop May 28, 2023
1 of 3 checks passed
@jdddog jdddog deleted the feature/workflow-config-file branch May 28, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants