-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/workflow config file #158
Conversation
5afb12e
to
978afb1
Compare
8b5679c
to
72007f4
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #158 +/- ##
===========================================
- Coverage 96.93% 96.01% -0.92%
===========================================
Files 30 19 -11
Lines 4468 4621 +153
Branches 601 615 +14
===========================================
+ Hits 4331 4437 +106
- Misses 68 111 +43
- Partials 69 73 +4
☔ View full report in Codecov by Sentry. |
9cc67ab
to
2e4e2f4
Compare
academic_observatory_workflows/workflows/crossref_events_telescope.py
Outdated
Show resolved
Hide resolved
academic_observatory_workflows/workflows/unpaywall_telescope.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank Jamie, the changes all look really good. Just a few very minor comments that would be good to take a look at before merging.
Thanks for your review Keegan, I've made most of the changes apart from the DOI query / dummy task ones. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking into the suggestions. Looks really good, Jamie 👍
No description provided.