Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pendulum datetime handler to date normalisation #659

Merged
merged 3 commits into from
Jun 6, 2024

Conversation

keegansmith21
Copy link
Contributor

@keegansmith21 keegansmith21 commented Jun 5, 2024

I foolishly expected the pendulum datetimes and python datetimes to behave the same, but they don't - perhaps because of versioning issues. So I made an extra step to convert the pendulum datetime to a string first.

@keegansmith21 keegansmith21 changed the base branch from main to feature/astro-refactor June 5, 2024 00:19
@keegansmith21 keegansmith21 marked this pull request as ready for review June 5, 2024 01:13
@keegansmith21 keegansmith21 requested a review from jdddog June 5, 2024 01:13
Copy link
Contributor

@jdddog jdddog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Keegan!

@jdddog jdddog merged commit a4fa9b3 into feature/astro-refactor Jun 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants